roachtest: output error and bump vmodule on lease preferences test #107900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `lease-preferences` roachtest did not log the state of preference conformance on timeout. This commit updates the error check, hit on timeout, to show the result. Also bump the vmodule settings to show lease acquisitions and lease preference errors. Epic: none Informs: cockroachdb#107862 Release note: None
|
This change is |
kvoli
requested review from
herkolategan,
srosenberg and
erikgrinaker
and removed request for
a team
erikgrinaker
approved these changes
Jul 31, 2023
| @@ -188,7 +188,8 @@ func runLeasePreferences( | |||
| // dc=2: n3 n4 | |||
| // ... | |||
| // dc=N: n2N-1 n2N | |||
| fmt.Sprintf("--locality=region=fake-region,zone=fake-zone,dc=%d", (node-1)/2+1)) | |||
| fmt.Sprintf("--locality=region=fake-region,zone=fake-zone,dc=%d", (node-1)/2+1), | |||
| "--vmodule=replica_proposal=2,replicate_queue=3,replicate=3") | |||
There was a problem hiding this comment.
Did you check that this won't be too noisy?
There was a problem hiding this comment.
I've looked at the logs few times with this change, whilst debugging the failure linked.
It's fine for cockroach.log logging, since there's no workload running. Turning it on after the initial splits/scatter would be better, but I'd rather have it all.
|
TYFTR bors r=erikgrinaker |
|
Build succeeded: |
|
blathers backport 23.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
lease-preferencesroachtest did not log the state of preference conformance on timeout. This commit updates the error check, hit on timeout, to show the result.Also bump the vmodule settings to show lease acquisitions and lease preference errors.
Epic: none
Informs: #107862
Release note: None