*: use must instead of logcrash.ReportOrPanic
#107846
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
erikgrinaker
force-pushed
the
must-logcrash
branch
from
1db5159 to
288e1b9
Compare
Epic: none Release note: None
Epic: none Release note: None
This patch removes the cluster setting `debug.panic_on_failed_assertions` in favor of the environment variable `COCKROACH_FATAL_ASSERTIONS`. Environment variables do not depend on a functional KV subsystem for propagation and are thus more reliable. They also avoid having to thread cluster settings through the code. They are less convenient, but we rarely if ever expect users to enable fatal assertions, as they are more for use in tests and development. Epic: none Release note: None
erikgrinaker
force-pushed
the
must-logcrash
branch
from
288e1b9 to
d5f275c
Compare
|
No point reviewing this until we address #107790 (review), so marking as draft. |
|
Closing, as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*: use
mustinstead oflogcrash.ReportOrPaniclogcrash: remove
ReportOrPanic()logcrash: remove
debug.panic_on_failed_assertionsThis patch removes the cluster setting
debug.panic_on_failed_assertionsin favor of the environment variableCOCKROACH_FATAL_ASSERTIONS. Environment variables do not depend on a functional KV subsystem for propagation and are thus more reliable. They also avoid having to thread cluster settings through the code. They are less convenient, but we rarely if ever expect users to enable fatal assertions, as they are more for use in tests and development.Resolves #107428.
Epic: none
Release note: None