schemafeed: improve some tests #107810
Merged
schemafeed: improve some tests #107810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
miretskiy
approved these changes
Jul 28, 2023
yuzefovich
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @adityamaru, @knz, and @shermanCRL)
pkg/ccl/changefeedccl/schemafeed/table_event_filter_datadriven_test.go line 69 at r1 (raw file):
ts, sqlDB, _ := serverutils.StartServer(t, base.TestServerArgs{ // TODO(ajwerner): Otherwise the test gets skipped due to some CCL warning. DefaultTestTenant: base.TODOTestTenantDisabled,
nit: update the linter.
knz
force-pushed
the
20230728-schemafeed-tests
branch
from
0a32eb4 to
5f240b7
Compare
Release note: None
knz
force-pushed
the
20230728-schemafeed-tests
branch
from
5f240b7 to
f1d749a
Compare
knz
commented
Jul 28, 2023
There was a problem hiding this comment.
Reviewable status:
pkg/ccl/changefeedccl/schemafeed/table_event_filter_datadriven_test.go line 69 at r1 (raw file):
Previously, yuzefovich (Yahor Yuzefovich) wrote…
nit: update the linter.
Done.
|
TFYRs! bors r=miretskiy,yuzefovich |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #76378
Release note: None
Epic: CRDB-18499