diagnosticsccl: fix TestUsageQuantization #107807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestUsageQuantization failed with secondary tenants because the test's server.TestingKnobs were not being passed through to test tenant creation. Resolves cockroachdb#106901 Epic: none Release note: None
zachlite
requested review from
smg260 and
renatolabs
and removed request for
a team
|
This change is |
j82w
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @renatolabs and @smg260)
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestUsageQuantization failed with secondary tenants because the test's server.TestingKnobs were not being passed through to test tenant creation.
Resolves #106901
Epic: none
Release note: None