Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: roachtest: include link to testeng grafana in issue posts #107806

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

annrpom
Copy link
Contributor

@annrpom annrpom commented Jul 28, 2023

Backport 2/2 commits from #107391.

/cc @cockroachdb/release


This adds a link, populated with relevant cluster name and test timeframe, to the testeng grafana instance for failed roachtests.

Fixes: #105894
Release note: None


Release justification: adds helpful testeng grafana link to failed roachtests

This change refactors createPostRequest in two ways:
 - It adds two new time.Time parameters, setting up work for populating
   the testeng Grafana link.
 - Error handling by invoking t.Fatalf has been replaced with returning
   an `error`.
@annrpom annrpom requested a review from a team as a code owner July 28, 2023 17:00
@annrpom annrpom requested review from srosenberg and renatolabs and removed request for a team July 28, 2023 17:00
@blathers-crl
Copy link

blathers-crl bot commented Jul 28, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@annrpom annrpom requested a review from smg260 July 28, 2023 17:59
This adds a link, populated with relevant cluster name and test timeframe,
to the testeng grafana instance for failed roachtests.

Fixes: cockroachdb#105894
Release note: None
@annrpom annrpom force-pushed the backport23.1-107391 branch from b0ff1ae to 350f13f Compare August 3, 2023 20:47
@annrpom annrpom merged commit 8b6930c into cockroachdb:release-23.1 Aug 4, 2023
@annrpom
Copy link
Contributor Author

annrpom commented Aug 4, 2023

thank you, @srosenberg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants