plpgsql: add support for CONSTANT variable declarations #107682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
mgartner
approved these changes
Jul 27, 2023
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @chengxiong-ruan, @DrewKimball, and @rharding6373)
pkg/sql/opt/optbuilder/create_function.go line 250 at r1 (raw file):
stmtScope = plBuilder.build(stmt.AST, bodyScope) }) checkStmtVolatility(targetVolatility, stmtScope, stmt)
Can you add tests for mismatched volatility, if they don't already exist?
This patch ensures that PLpgSQL functions are built during function creation, not just during invocation. This ensures that compile-time errors are thrown when the function is created. This commit also tests and corrects the codes for some of the errors that can be thrown while building a PLpgSQL function. Note that some of the existing tests had to be removed since they called UDFs within other UDFs. We didn't catch this before because the restriction is only checked during function creation when the body statements are first built. Fixes cockroachdb#107681 Release note: None
It is possible to declare variables as CONSTANT in PLpgSQL. This will cause any attempt to assign to the variable to result in a compile-time error. This patch implements CONSTANT variables by adding a check whenever an assignment is built that the assigned variable is non-constant. Fixes cockroachdb#105241 Release note (sql change): Added support for CONSTANT variable declarations in PLpgSQL routines. Any assignment to a variable declared with the CONSTANT keyword will raise a compile-time error.
DrewKimball
force-pushed
the
plpgsql-constant
branch
from
a04d27f to
a181794
Compare
|
TFTRs! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plpgsql: validate PLpgSQL functions during creation
This patch ensures that PLpgSQL functions are built during function
creation, not just during invocation. This ensures that compile-time
errors are thrown when the function is created. This commit also tests
and corrects the codes for some of the errors that can be thrown while
building a PLpgSQL function.
Note that some of the existing tests had to be removed since they called
UDFs within other UDFs. We didn't catch this before because the restriction
is only checked during function creation when the body statements are first
built.
Fixes #107681
Release note: None
plpgsql: add support for CONSTANT variable declarations
It is possible to declare variables as CONSTANT in PLpgSQL. This will cause
any attempt to assign to the variable to result in a compile-time error.
This patch implements CONSTANT variables by adding a check whenever an
assignment is built that the assigned variable is non-constant.
Fixes #105241
Release note (sql change): Added support for CONSTANT variable
declarations in PLpgSQL routines. Any assignment to a variable declared
with the CONSTANT keyword will raise a compile-time error.