opt: remove Metadata.AllUserDefinedFunctions #107673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
DrewKimball
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @mgartner)
-- commits line 4 at r1:
[nit] mthoed -> method
mgartner
force-pushed
the
remove-all-user-defined-functions
branch
from
304b1eb to
0b83611
Compare
mgartner
commented
Jul 26, 2023
There was a problem hiding this comment.
Reviewable status:
Previously, DrewKimball (Drew Kimball) wrote…
[nit]
mthoed->method
Done.
|
bors r+ |
|
Build failed: |
The metadata method `AllUserDefinedFunctions` has been replaced with a new function `HasUserDefinedFunctions` which provides a simpler API without exposing the underlying UDF dependency map. The map is still available outside of the opt package via the `TestingUDFDeps` method which is designed for testing use only. Release note: None
mgartner
force-pushed
the
remove-all-user-defined-functions
branch
from
0b83611 to
a6a2ccc
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metadata method
AllUserDefinedFunctionshas been replaced with anew function
HasUserDefinedFunctionswhich provides a simpler APIwithout exposing the underlying UDF dependency map. The map is still
available outside of the opt package via the
TestingUDFDepsmethodwhich is designed for testing use only.
Epic: None
Release note: None