kv: test replay protection on all writes #107662
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a unit test to reproduce the behavior described in cockroachdb#103817 and seen in cockroachdb#67765, which currently is a bug in our implementation of the parallel commit protocol that results in the assertion failure known as `transaction unexpectedly committed`. The test currently validates the incorrect behavior of the known issue, though it is inded to be used to validate the potential fixes as proposed in cockroachdb#103817. Release note: None Part of: cockroachdb#103817
!DNM! This is intended to test the behavior of enabling replay protection for all writes, such that they will fail if an idempotent write replay is performed with a different timestamp at the same epoch and sequence for a transaction. Depends on cockroachdb#107596. Fixes: cockroachdb#103817 Release note (bug fix): TBD
|
This change is |
|
Btw you can use a draft PR for this next time, then it won't notify people except direct assignees. |
|
Thanks @tbg! I usually would but I (incorrectly) thought the CI suite for drafts would be different. TIL :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!DNM!
This is intended to test the behavior of enabling replay protection for
all writes, such that they will fail if an idempotent write replay is
performed with a different timestamp at the same epoch and sequence for
a transaction.
Depends on #107596.
Fixes: #103817
Release note (bug fix): TBD