Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: sql: fix crdb_internal.encode_key in some contexts #107603

Merged
merged 1 commit into from
Aug 1, 2023
Merged

release-23.1: sql: fix crdb_internal.encode_key in some contexts #107603

merged 1 commit into from
Aug 1, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jul 26, 2023 •
edited by yuzefovich
Loading

Backport 1/1 commits from #107512 on behalf of @yuzefovich.

/cc @cockroachdb/release

Previously, we forgot to set CatalogBuiltins for the internal planner which is used by crdb_internal.encode_key (which, in turn, is used to power SHOW RANGE ... FOR ROW), so evaluating it would lead to an error. For example, the internal planner is used in the backfill. This is now fixed.

Fixes: #106397.

Release note (bug fix): CockroachDB would previously return an error when using SHOW RANGE ... FOR ROW ... in CREATE TABLE ... AS ... construct, and this is now fixed.

Release justification: bug fix.

@yuzefovich
sql: fix crdb_internal.encode_key in some contexts
ebd6969 
Previously, we forgot to set `CatalogBuiltins` for the internal planner
which is used by `crdb_internal.encode_key` (which, in turn, is used to
power `SHOW RANGE ... FOR ROW`), so evaluating it would lead to an error.
For example, the internal planner is used in the backfill. This is now
fixed.

Release note (bug fix): CockroachDB would previously return an error
when using `SHOW RANGE ... FOR ROW ...` in `CREATE TABLE ... AS ...`
construct, and this is now fixed.
@blathers-crl blathers-crl bot requested a review from a team as a code owner July 26, 2023 06:07
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-107512 branch from 9657947 to 1c8153e Compare July 26, 2023 06:07
@blathers-crl
Copy link
Author

blathers-crl bot commented Jul 26, 2023 •
edited by yuzefovich
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jul 26, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-107512 branch from d781ff4 to ebd6969 Compare July 26, 2023 06:07
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@yuzefovich yuzefovich removed the request for review from mgartner July 26, 2023 15:44
rharding6373
rharding6373 approved these changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@rharding6373 rharding6373 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @ecwall and @yuzefovich)

@yuzefovich yuzefovich merged commit 54c0281 into release-23.1 Aug 1, 2023
@yuzefovich yuzefovich deleted the blathers/backport-release-23.1-107512 branch August 1, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rharding6373 rharding6373 rharding6373 approved these changes

@ecwall ecwall Awaiting requested review from ecwall

@yuzefovich yuzefovich Awaiting requested review from yuzefovich

Assignees

@yuzefovich yuzefovich

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @rharding6373 @yuzefovich