release-23.1: issues: use prefix match to check for existing issue #107569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
|
This change is |
renatolabs
reviewed
Jul 25, 2023
pkg/cmd/internal/issues/issues.go
Outdated
| result *github.IssuesSearchResult, expectedTitle string, | ||
| ) []github.Issue { | ||
| expectedTitleRegex := regexp.MustCompile(`^` + expectedTitle + `(\s+|$)`) |
There was a problem hiding this comment.
It just occurred to me: shouldn't we regexp.QuoteMeta(expectedTitle)? I don't think this is an immediate problem given our test names and title function, but could become a silent bug if those were to change. What's worse, MustCompile would crash the entire roachtest nightly run.
There was a problem hiding this comment.
yeah that's definitely a good idea
renatolabs
approved these changes
Jul 25, 2023
It is conventional to annotate a test failure issue title with some additional information about thef failure cause. The previous logic was too strict in requiring an exact title match. Now it will match as long as the title matches exactly OR if the prefix matches and is followed by whitespace. Release note: None
rafiss
force-pushed
the
backport23.1-107444
branch
from
5b01e8d to
46f4ddb
Compare
|
Created #107574 on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #107444.
/cc @cockroachdb/release
It is conventional to annotate a test failure issue title with some additional information about the failure cause. The previous logic was too strict in requiring an exact title match. Now it will match as long as the title matches exactly OR if the prefix matches and is followed by whitespace.
Example:
I added a suffix to
sql/tests: TestRandomSyntaxFunctions failed [panic in request_job_execution_details]since the issue was with a function the jobs team added. But the next day #107237 was opened anew. This PR would prevent that from happening.Release justification: non production code change
Epic: None
Release note: None