Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: sql: fix CREATE MATERIALIZED VIEW AS schema change job description #107471

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jul 24, 2023

Backport 1/1 commits from #107447 on behalf of @ecwall.

/cc @cockroachdb/release


Fixes #107445

This changes the CREATE MATERIALIZED VIEW AS schema change job description SQL syntax. For example

CREATE VIEW "v" AS "SELECT t.id FROM movr.public.t";

becomes

CREATE MATERIALIZED VIEW defaultdb.public.v AS SELECT t.id FROM defaultdb.public.t WITH DATA;

Release note (bug fix): Fix CREATE MATERIALIZED VIEW AS schema change job description SQL syntax.


Release justification: Schema change job description fix.

Fixes #107445

This changes the CREATE MATERIALIZED VIEW AS schema change job description SQL
syntax.
For example
```
CREATE VIEW "v" AS "SELECT t.id FROM movr.public.t";
```
becomes
```
CREATE MATERIALIZED VIEW defaultdb.public.v AS SELECT t.id FROM defaultdb.public.t WITH DATA;
```

Release note (bug fix): Fix CREATE MATERIALIZED VIEW AS schema change job description SQL syntax.
@blathers-crl blathers-crl bot requested review from a team as code owners July 24, 2023 18:32
@blathers-crl blathers-crl bot requested a review from rytaft July 24, 2023 18:32
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-107447 branch from bebdf99 to 6826cc1 Compare July 24, 2023 18:32
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jul 24, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-107447 branch from 415ccca to b59fc36 Compare July 24, 2023 18:32
@blathers-crl
Copy link
Author

blathers-crl bot commented Jul 24, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested review from fqazi, mgartner and msirek July 24, 2023 18:32
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@fqazi fqazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @mgartner, @msirek, and @rytaft)

@ecwall ecwall merged commit 7ef1c09 into release-23.1 Jul 25, 2023
@ecwall ecwall deleted the blathers/backport-release-23.1-107447 branch July 25, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants