Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "github-pull-request-make: temporary workaround" #107453

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

postamar
Copy link
Contributor

@postamar postamar commented Jul 24, 2023

This reverts commit 2bd61c0.

Relates to #106920.

@postamar postamar requested a review from a team as a code owner July 24, 2023 15:45
@blathers-crl
Copy link

blathers-crl bot commented Jul 24, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@postamar postamar requested a review from fqazi July 24, 2023 15:46
Copy link
Collaborator

@fqazi fqazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @postamar)

This reverts commit 2bd61c0.

Informs cockroachdb#106920.

Release note: None
@postamar postamar force-pushed the revert-workaround branch from de2dcd4 to 13f1ab0 Compare July 24, 2023 15:48
@postamar
Copy link
Contributor Author

Thanks for the review!

bors r+

@craig
Copy link
Contributor

craig bot commented Jul 24, 2023

Build succeeded:

@craig craig bot merged commit 06fb4c1 into cockroachdb:master Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants