Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: bump Pebble to 94f91669 #107392

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

RaduBerinde
Copy link
Member

@RaduBerinde RaduBerinde commented Jul 21, 2023

94f91669 db: rename Experimental.SharedStorage to RemoteStorage in Options
c62c9127 objstorage: rename objstorage/shared package to remote
692f3b61 vfs: move errorfs package to vfs dir to allow use in CockroachDB
5e550364 cmd/pebble: allow passing an explicit checkpoint directory path
9c3f337a cmd/replay: always log checkpoint initialization
0cd8f1b8 replay: calculate separate write stall metrics for each reason
f9d08867 cmd/pebble: use non-default block cache size in replay tool
d0e583f8 *: improve humanize format
5e76dfab db: minor update of comment for TargetByteDeletionRate
456a2a2a objstorage: rename Shared to Remote in the objstorage provider API

Release note (general change): Formatting of byte figures in Pebble logs has been improved; any tools that parse these logs might need updating.

Epic: none

@RaduBerinde RaduBerinde requested review from itsbilal and jbowens July 21, 2023 21:20
@RaduBerinde RaduBerinde requested review from a team as code owners July 21, 2023 21:20
@blathers-crl
Copy link

blathers-crl bot commented Jul 21, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

94f91669 db: rename Experimental.SharedStorage to RemoteStorage in Options
c62c9127 objstorage: rename objstorage/shared package to remote
692f3b61 vfs: move errorfs package to vfs dir to allow use in CockroachDB
5e550364 cmd/pebble: allow passing an explicit checkpoint directory path
9c3f337a cmd/replay: always log checkpoint initialization
0cd8f1b8 replay: calculate separate write stall metrics for each reason
f9d08867 cmd/pebble: use non-default block cache size in replay tool
d0e583f8 *: improve humanize format
5e76dfab db: minor update of comment for TargetByteDeletionRate
456a2a2a objstorage: rename Shared to Remote in the objstorage provider API

Release note (general change): Formatting of byte figures in Pebble
logs has been improved; any tools that parse these logs might need
updating.

Epic: none
@RaduBerinde RaduBerinde force-pushed the bump-pebble-shared-rename branch from c4adf1f to 9d63c92 Compare July 21, 2023 21:20
Copy link
Collaborator

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RaduBerinde
Copy link
Member Author

bors r+

@craig
Copy link
Contributor

craig bot commented Jul 21, 2023

Build succeeded:

@craig craig bot merged commit 8d10f15 into cockroachdb:master Jul 21, 2023
@RaduBerinde RaduBerinde deleted the bump-pebble-shared-rename branch July 22, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants