Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: upgrade pgx v4 to 4.18.1 #107383

Merged
merged 1 commit into from
Aug 7, 2023
Merged

go.mod: upgrade pgx v4 to 4.18.1 #107383

merged 1 commit into from
Aug 7, 2023

Conversation

sean-
Copy link
Collaborator

@sean- sean- commented Jul 21, 2023

Upgrade v4.16.1 to v.4.18.1, bringing in puddle v1.3.0 which fixes some edge cases related to context cancelation.

d15cc95a Add fix for using a context with a value in BeforeConnect
3edc1b5b Fix query sanitizer
dfce986b Fix panic when logging batch error
72fe5949 Upgrade to puddle v1.3.0
bce26b85 Fix atomic alignment on 32-bit platforms
1d748d9b Failsafe timeout for background pool connections
7ce634d6 Ensure there is a timeout for background pool connections
91c9e841 Ignore cancellation in puddle constructor
a814153a pgxpool: health check should avoid going below minConns

Release note: None

@sean- sean- self-assigned this Jul 21, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@sean- sean- requested a review from a team as a code owner July 21, 2023 20:34
@sean- sean- force-pushed the upgrade-pgx-v4 branch 2 times, most recently from 3e170db to b62cc15 Compare July 26, 2023 00:20
d15cc95a Add fix for using a context with a value in BeforeConnect
3edc1b5b Fix query sanitizer
dfce986b Fix panic when logging batch error
72fe5949 Upgrade to puddle v1.3.0
bce26b85 Fix atomic alignment on 32-bit platforms
1d748d9b Failsafe timeout for background pool connections
7ce634d6 Ensure there is a timeout for background pool connections
91c9e841 Ignore cancellation in puddle constructor
a814153a pgxpool: health check should avoid going below minConns

Release note: None
@sean-
Copy link
Collaborator Author

sean- commented Jul 26, 2023

bors r+

@craig
Copy link
Contributor

craig bot commented Jul 26, 2023

👎 Rejected by too few approved reviews

@sean- sean- requested review from nicktrav and srosenberg July 26, 2023 19:09
@srosenberg
Copy link
Member

@sean-
Copy link
Collaborator Author

sean- commented Aug 7, 2023

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 7, 2023

Build succeeded:

@craig craig bot merged commit 8c1ff51 into master Aug 7, 2023
@craig craig bot deleted the upgrade-pgx-v4 branch August 7, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants