backupccl: possibly deflake TestBackupRestoreAppend #107334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In CI we've seen this test fail with:
backup_test.go:670: error scanning '&{<nil> 0xc019c5b580}': pq:
restart transaction: TransactionRetryWithProtoRefreshError:
TransactionRetryError: retry txn (RETRY_SERIALIZABLE - failed
preemptive refresh): "sql txn" meta={id=77054b51 key=/Table/121/1
pri=0.03587869 epo=0 ts=1689916873.568949604,1
min=1689916873.436580640,0 seq=1000} lock=true stat=PENDING
rts=1689916873.436580640,0 wto=false gul=1689916873.936580640,0
The `RETURNING` clauses on these two `UPDATE` statements prevent
automatic transaction retries.
Here we wrap the queries in an explicit transaction with a retry loop
which should prevent the test failure test, assuming that the update
isn't so contended it won't ever complete.
I am unable to stress this enough locally to reproduce this error.
Probably Fixes cockroachdb#107330
Epic: none
Release note: None
stevendanna
added
the
backport-23.1.x
|
This change is |
adityamaru
approved these changes
Jul 21, 2023
|
TFTR! bors r=adityamaru Failure is TestBackupRestoreJobTagAndLabel which I've skipped under race in another PR. |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CI we've seen this test fail with:
The
RETURNINGclauses on these twoUPDATEstatements prevent automatic transaction retries.Here we wrap the queries in an explicit transaction with a retry loop which should prevent the test failure test, assuming that the update isn't so contended it won't ever complete.
I am unable to stress this enough locally to reproduce this error.
Probably Fixes #107330
Epic: none
Release note: None