builtins: crdb_internal.sstable_metrics fixes
#107303
Merged
+15
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
raggar
force-pushed
the
rahul_sstable_metric_fixes
branch
from
b38858f to
f5f2284
Compare
RaduBerinde
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @jbowens)
This pr has the following fixes for the builtin `crdb_internal.sstable_metrics` 1. Remove the ',' from `node_id` 2. Change `approximate_span_bytes` to be a `uint64` instead of `[]byte` 3. Convert the `MVCCTimeInterval` user property to be human readable. Informs: cockroachdb#102604 Release-note: None
raggar
force-pushed
the
rahul_sstable_metric_fixes
branch
from
f5f2284 to
ceb5cd5
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr has the following fixes for the builtin
crdb_internal.sstable_metrics,fromnode_idapproximate_span_bytesto be auint64instead of[]byteNext Steps:
MVCCTimeIntervaldisplay formatInforms: #102604
Release-note: None