Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backupccl: read size if needed, fix URIs #107250

Merged
merged 2 commits into from
Jul 20, 2023
Merged

backupccl: read size if needed, fix URIs #107250

merged 2 commits into from
Jul 20, 2023

Conversation

dt
Copy link
Member

@dt dt commented Jul 20, 2023

Release note: none.
Epic: none.

@dt dt requested review from itsbilal and msbutler July 20, 2023 11:33
@dt dt requested a review from a team as a code owner July 20, 2023 11:33
@dt dt requested a review from a team July 20, 2023 11:33
@dt dt requested review from a team as code owners July 20, 2023 11:33
@dt dt requested a review from msirek July 20, 2023 11:33
@blathers-crl
Copy link

blathers-crl bot commented Jul 20, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@dt dt force-pushed the size-just-in-time branch 2 times, most recently from 32bbc54 to 0c1f996 Compare July 20, 2023 13:43
@dt dt changed the title backupccl: read size on the fly if needed backupccl: read size if needed, fix URIs Jul 20, 2023
dt added 2 commits July 20, 2023 14:15
@dt
backupccl: read size on the fly if needed
021c072 
Release note: none.
@dt
backupccl: fix online restore file URIs
b13277e 
This broke in the switch to genSpans.

Release note: none.
Epic: none.
@dt dt force-pushed the size-just-in-time branch from 0c1f996 to b13277e Compare July 20, 2023 14:19
@dt
Copy link
Member Author

dt commented Jul 20, 2023

TFTR!

bors r+

@craig
Copy link
Contributor

craig bot commented Jul 20, 2023

Build succeeded:

@craig craig bot merged commit 98cd2f0 into cockroachdb:master Jul 20, 2023
@dt dt deleted the size-just-in-time branch July 20, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msbutler msbutler msbutler approved these changes

@itsbilal itsbilal Awaiting requested review from itsbilal

@msirek msirek Awaiting requested review from msirek msirek was automatically assigned from cockroachdb/sql-queries

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dt @cockroach-teamcity @msbutler