-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: use txn.NewBatch instead of &kv.Batch{} #107236
Conversation
Maybe add a linter for this too (like simple text based, over |
There is a usage in pkg/sql/tenant_gc.go that I don't know how to address. I was planning to reach out to the multi-tenant team to see if that can be addressed separately. There are also some in pkg/server that I don't know what to do about. |
I also found usages like this one: cockroach/pkg/sql/gcjob/table_garbage_collection.go Lines 245 to 251 in 5acb999
It seems like it would be better to have a linter or runtime assertion to check that |
This will make these requests properly passes along the admission control headers. There are more usages in addition to these ones that are not trivial to address. Release note: None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @irfansharif and @yuzefovich)
tftr! bors r=fqazi |
This PR was included in a batch that was canceled, it will be automatically retried |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 3bd2698 to blathers/backport-release-22.2-107236: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. error setting reviewers, but backport branch blathers/backport-release-23.1-107236 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/107472/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. [] Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This will make these requests properly passes along the admission control headers.
informs #79212
Epic: None
Release note: None