Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: tests: fix stories files #107222

Merged
merged 1 commit into from
Jul 20, 2023
Merged

release-23.1: tests: fix stories files #107222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/ui/workspaces/cluster-ui/src/transactionDetails/transactionDetails.fixture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,3 +541,5 @@ export const timeScale: TimeScale = {
fixedWindowEnd: moment.utc("2021.12.31"),
key: "Custom",
};

export const requestTime = moment.utc("2023.01.5");
9 changes: 9 additions & 0 deletions pkg/ui/workspaces/cluster-ui/src/transactionDetails/transactionDetails.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import { noop } from "lodash";
import {
error,
nodeRegions,
requestTime,
routeProps,
timeScale,
transaction,
Expand Down Expand Up @@ -53,6 +54,8 @@ storiesOf("Transactions Details", module)
limit={100}
reqSortSetting={StatsSortOptions.SERVICE_LAT}
isDataValid={true}
requestTime={requestTime}
onRequestTimeChange={noop}
/>
))
.add("with loading indicator", () => (
Expand All @@ -76,6 +79,8 @@ storiesOf("Transactions Details", module)
limit={100}
reqSortSetting={StatsSortOptions.SERVICE_LAT}
isDataValid={true}
requestTime={requestTime}
onRequestTimeChange={noop}
/>
))
.add("with error alert", () => (
Expand All @@ -100,6 +105,8 @@ storiesOf("Transactions Details", module)
limit={100}
reqSortSetting={StatsSortOptions.SERVICE_LAT}
isDataValid={true}
requestTime={moment()}
onRequestTimeChange={noop}
/>
))
.add("No data for this time frame; no cached transaction text", () => {
Expand All @@ -124,6 +131,8 @@ storiesOf("Transactions Details", module)
limit={100}
reqSortSetting={StatsSortOptions.SERVICE_LAT}
isDataValid={true}
requestTime={requestTime}
onRequestTimeChange={noop}
/>
);
});
1 change: 1 addition & 0 deletions pkg/ui/workspaces/cluster-ui/src/transactionsPage/transactions.fixture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ export const timeScale: TimeScale = {
export const timestamp = new protos.google.protobuf.Timestamp({
seconds: new Long(Date.parse("Sep 15 2021 01:00:00 GMT") * 1e-3),
});
export const requestTime = moment.utc("2023.01.5");

export const sortSetting: SortSetting = {
ascending: false,
Expand Down
11 changes: 11 additions & 0 deletions pkg/ui/workspaces/cluster-ui/src/transactionsPage/transactionsPage.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import {
filters,
lastUpdated,
nodeRegions,
requestTime,
routeProps,
sortSetting,
timeScale,
Expand Down Expand Up @@ -61,6 +62,8 @@ storiesOf("Transactions Page", module)
onChangeLimit={noop}
onChangeReqSort={noop}
onApplySearchCriteria={noop}
requestTime={requestTime}
onRequestTimeChange={noop}
/>
))
.add("without data", () => {
Expand Down Expand Up @@ -89,6 +92,8 @@ storiesOf("Transactions Page", module)
onChangeLimit={noop}
onChangeReqSort={noop}
onApplySearchCriteria={noop}
requestTime={requestTime}
onRequestTimeChange={noop}
/>
);
})
Expand Down Expand Up @@ -125,6 +130,8 @@ storiesOf("Transactions Page", module)
onChangeLimit={noop}
onChangeReqSort={noop}
onApplySearchCriteria={noop}
requestTime={requestTime}
onRequestTimeChange={noop}
/>
);
})
Expand Down Expand Up @@ -154,6 +161,8 @@ storiesOf("Transactions Page", module)
onChangeLimit={noop}
onChangeReqSort={noop}
onApplySearchCriteria={noop}
requestTime={requestTime}
onRequestTimeChange={noop}
/>
);
})
Expand Down Expand Up @@ -190,6 +199,8 @@ storiesOf("Transactions Page", module)
onChangeLimit={noop}
onChangeReqSort={noop}
onApplySearchCriteria={noop}
requestTime={requestTime}
onRequestTimeChange={noop}
/>
);
});