Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: ui: fix creation index syntax on console #107218

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jul 19, 2023

Backport 1/1 commits from #107170 on behalf of @maryliag.

/cc @cockroachdb/release


With an update to make the table name fully qualified, the index name was also using the fully qualified name, which contains ".", and that causes an invalid syntax since index name can't have periods.
Having the qualified name is not important for the index name itself, so this commit fixes by ignoring that part and using just the table name, how it was doing previously. It also fixes an invalid syntax when there were spaces on the name generate.

It also add a little more observability into indexes being created with STORING clause, adding that to the suffix of the index creation.

Fixes #107168

Before
Screenshot 2023-07-19 at 10 23 21 AM

After
https://www.loom.com/share/33da8b46fc9e4f72944c1d0ab943dea0

Release note (bug fix): Index recommendation on the UI no longer uses the full qualified name of a table to create an index name, allowing the creating of indexes directly from the Console to work.


Release justification: bug fix

With an update to make the table name fully qualified,
the inedx name was also using the fully qualified name,
which contains ".", and that causes an invalid syntax
since index name can't have periods.
Having the qualified name is not important for the index
name itself, so this commit fixes by ignoring that part
and using just the table name, how it was doing previously.
It also fixes an invalid syntax when there were spaces on
the name generate.

It also add a little more observability into indexes
being created with STORING clause, adding that to the
suffix of the index creation.

Fixes #107168

Release note (bug fix): Index recommendation on the UI no
longer uses the full qualified name of a table to create an
index name, allowing the creating of indexes directly from
the Console to work.
@blathers-crl blathers-crl bot requested a review from a team July 19, 2023 22:48
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-107170 branch 2 times, most recently from 9eddd49 to aa84979 Compare July 19, 2023 22:48
@blathers-crl
Copy link
Author

blathers-crl bot commented Jul 19, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jul 19, 2023
@blathers-crl blathers-crl bot requested a review from zachlite July 19, 2023 22:49
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@maryliag maryliag requested a review from a team July 19, 2023 23:22
@maryliag maryliag merged commit 79a6c16 into release-23.1 Jul 20, 2023
@maryliag maryliag deleted the blathers/backport-release-23.1-107170 branch July 20, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants