server: split test code into sub-packages and files #107135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
knz
force-pushed
the
20230719-server-refactor
branch
from
303b7f8 to
5bfb191
Compare
knz
force-pushed
the
20230719-server-refactor
branch
2 times, most recently
from
a4060b8 to
626fb1b
Compare
knz
force-pushed
the
20230719-server-refactor
branch
from
626fb1b to
723ab3b
Compare
Release note: None
knz
force-pushed
the
20230719-server-refactor
branch
from
723ab3b to
d18e3f3
Compare
knz
requested review from
herkolategan,
renatolabs,
abarganier and
bananabrick
and removed request for
a team
New sub-packages: - `storage_api`: unit tests for API endpoints specific to the KV/storage layer. - `application_api`: unit tests for API endpoints valid for application servers, including for secondary tenants. - `privchecker`: SQL authorization interface for API handlers. (previously: `adminPrivilegeChecker`) - `authserver`: HTTP/RPC authentication code. (previously: `authenticationServer`) - `srverrors`: error objects suitable for return from API handlers. - `srvtestutils`: common helpers for test code. Release note: None
knz
force-pushed
the
20230719-server-refactor
branch
from
d18e3f3 to
c5e3cf4
Compare
craig bot
pushed a commit
that referenced
this pull request
Jul 19, 2023
106928: jobsccl: remove some uses of TODOTestTenantDisabled, simplify test code r=yuzefovich a=knz First commits from #107135. Epic: CRDB-18499 Informs #76378. 107113: dev: perform `chmod` in `/tmp`, not `/artifacts` r=rail a=rickystewart This avoids an error in case your `artifacts` directory has some restrictive permissions. There's no functional difference here, we just copy to `/tmp` and do the `chmod` there before copying to the final destination directory. [Internal discussion](https://cockroachlabs.slack.com/archives/C019A8NANH0/p1689598801368169) Epic: none Release note: None Co-authored-by: Raphael 'kena' Poss <[email protected]> Co-authored-by: Ricky Stewart <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic: CRDB-18499
Informs #76378.
New sub-packages:
storage_api: unit tests for API endpoints specificto the KV/storage layer.
application_api: unit tests for API endpoints valid forapplication servers, including for secondary tenants.
privchecker: SQL authorization interface for API handlers.(previously:
adminPrivilegeChecker)authserver: HTTP/RPC authentication code.(previously:
authenticationServer)srverrors: error objects suitable for return from API handlers.srvtestutils: common helpers for test code.