testutils,roachtest: only use private bucket in private tests #107073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
renatolabs
force-pushed
the
rc/fix-private-bucket-nightly-tests
branch
3 times, most recently
from
fd554ef to
c991349
Compare
This fixes an issue with the default location for backups taken during tests that use a real GCS bucket. Previously, some of these backups were using the hardcoded private bucket name, causing many tests to fail with permission errors. In this commit, we centralize the logic for figuring out which bucket to use in a `testutils` function, and reuse that across logic tests and roachtests. Fixes: cockroachdb#107056 Release note: None
Epic: none Release note: None
renatolabs
force-pushed
the
rc/fix-private-bucket-nightly-tests
branch
from
c991349 to
590b9e9
Compare
renatolabs
requested review from
herkolategan and
srosenberg
and removed request for
a team
|
A random sample of roachtests is running on this branch ( So far, multiple tests have passed, including tests that have the default backup schedule enabled, so there's good reason to believe things are working again. Opening for review. |
srosenberg
approved these changes
Jul 18, 2023
|
TFTR! bors r=srosenberg |
jlinder
approved these changes
Jul 18, 2023
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the default location for backups taken during tests that use a real GCS bucket. Previously, some of these backups were using the hardcoded private bucket name, causing many tests to fail with permission errors.
In this commit, we centralize the logic for figuring out which bucket to use in a
testutilsfunction, and reuse that across logic tests and roachtests.Fixes: #107056
Release note: None