Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvserver/gc: make TestEndToEndGC work with secondary tenants #106830

Merged
merged 1 commit into from
Jul 17, 2023
Merged

kvserver/gc: make TestEndToEndGC work with secondary tenants #106830

merged 1 commit into from
Jul 17, 2023

Conversation

knz
Copy link
Contributor

@knz knz commented Jul 14, 2023

Informs #76378
Epic: CRDB-18499

Release note: None

@knz knz requested review from erikgrinaker and stevendanna July 14, 2023 15:24
@knz knz requested a review from a team as a code owner July 14, 2023 15:24
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz force-pushed the 20230714-gc-test branch from 829d37a to f4d7327 Compare July 14, 2023 15:24
@knz knz changed the title kvserver/gc: make TEstEndToEndGC work with secondary tenants kvserver/gc: make TestEndToEndGC work with secondary tenants Jul 14, 2023
@knz knz force-pushed the 20230714-gc-test branch from f4d7327 to 5e882f9 Compare July 14, 2023 16:44
@knz knz requested a review from aliher1911 July 14, 2023 17:01
@erikgrinaker
Copy link
Contributor

I'll let @aliher1911 pick this up.

@erikgrinaker erikgrinaker removed their request for review July 17, 2023 08:33
aliher1911
aliher1911 approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@aliher1911 aliher1911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Do we have some TLDR on how should tests be written to work with our future vision?

@knz
Copy link
Contributor Author

knz commented Jul 17, 2023

We are working on improving the test APIs and will get this documented when it feels ready for use.

@knz
Copy link
Contributor Author

knz commented Jul 17, 2023

TFYR!

bors r=aliher1911

@craig
Copy link
Contributor

craig bot commented Jul 17, 2023

Build succeeded:

@craig craig bot merged commit e0d4e62 into cockroachdb:master Jul 17, 2023
@knz knz deleted the 20230714-gc-test branch July 17, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliher1911 aliher1911 aliher1911 approved these changes

@stevendanna stevendanna Awaiting requested review from stevendanna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@knz @cockroach-teamcity @erikgrinaker @aliher1911