spanconfigccl: remove uses of TODOTestTenantDisabled
#106822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
stevendanna
approved these changes
Jul 14, 2023
| @@ -39,7 +39,7 @@ func TestCommitTSIntervals(t *testing.T) { | |||
| var i interceptor | |||
| ts, _, _ := serverutils.StartServer(t, base.TestServerArgs{ | |||
| // Manually starts a tenant below. No need to start one here. | |||
There was a problem hiding this comment.
Minor but this comment is now a bit redundant with the constant name.
There's a mix of tests that control their tenants directly, and tests that should really work with virtualization enabled but don't. Followup issues: cockroachdb#106821 and cockroachdb#106818. Release note: None
knz
force-pushed
the
20230714-spanconfig-mt-testing
branch
from
c09c13e to
68ca3ec
Compare
|
TFYR bors r=stevendanna |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #76378 .
Epic: CRDB-18499
There's a mix of tests that control their tenants directly, and tests that should really work with virtualization enabled but don't.
Followup issues: #106821 and #106818.
Release note: None