tenantcostclient: tighten query RU estimate test #106769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The query RU estimate test involves two runs of test queries: - via EXPLAIN ANALYZE to get the RU estimate - "vanilla" way and getting the precise RU usage. One of the test queries is a large INSERT, and previously we didn't delete the data after the first run. As a result, the second run would operate on 2x size of the data set. This commit fixes that oversight by including a DELETE query into the test query set which allows us to tighten the delta margin from 0.75 to 0.05 (got no failures in over 1k runs with 0.05 now). Release note: None
|
This change is |
DrewKimball
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
|
Got no failures in 1hr of stressing, should be good. TFTR! bors r+ |
|
Build succeeded: |
yuzefovich
added a commit
to yuzefovich/cockroach
that referenced
this pull request
Sep 8, 2023
In cockroachdb#106769 we tightened the RU estimate test to use 0.05 allowance, but we just saw a case where the difference was on the order of 0.2, so this commit bumps the allowed delta to 0.25 (which is still much better than 0.75 before cockroachdb#106769). Release note: None
craig bot
pushed a commit
that referenced
this pull request
Sep 8, 2023
110191: kvprober: make the planner thread-safe to fix test-only race r=nvanbenschoten a=joshimhoff #109564 **kvprober: make the planner thread-safe to fix test-only race** This commit makes the planner thread-safe, in order to fix a test-only data race. This commit also un-skips the test that was skipped, when this bug was discovered. Fixes: #109564 Release note: None. 110275: tenantcostclient: relax expectation in RU estimate test r=yuzefovich a=yuzefovich In #106769 we tightened the RU estimate test to use 0.05 allowance, but we just saw a case where the difference was on the order of 0.2, so this commit bumps the allowed delta to 0.25 (which is still much better than 0.75 before #106769). Fixes: #109732. Release note: None Co-authored-by: Josh Imhoff <[email protected]> Co-authored-by: Yahor Yuzefovich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query RU estimate test involves two runs of test queries:
One of the test queries is a large INSERT, and previously we didn't delete the data after the first run. As a result, the second run would operate on 2x size of the data set. This commit fixes that oversight by including a DELETE query into the test query set which allows us to tighten the delta margin from 0.75 to 0.05 (got no failures in over 1k runs with 0.05 now).
Epic: None
Release note: None