kvserver: log receiver snapshot trace on context errors #106742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Alternate approach to #106655. |
AlexTalks
force-pushed
the
log_trace_at_rpc
branch
3 times, most recently
from
ac83d72 to
ee6e8c1
Compare
knz
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
LGTM, well done!
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @AlexTalks)
pkg/kv/kvserver/store_snapshot.go line 391 at r1 (raw file):
snapshotCtx := ctx ctx, rSp := tracing.EnsureChildSpan(ctx, s.cfg.Tracer(), "receive snapshot data") defer rSp.Finish() // Ensure that the tracing span is closed, even if Receive errors
nit: period at end of comment.
In cockroachdb#106363, the receiver side of snapshots was modified to log the trace of the current context when context errors (such as timeouts or client-side context cancellation) occur. This refactors that change to log these traces whenever there is any context-based errors that occur during receiver-side handling of the MultiRaft/RaftSnapshot streaming RPC. This includes errors while receiving requests or sending responses from the server side of a snapshot - i.e. any time that the traces cannot be collected and returned to the client. Additionally, testing for these scenarios has been incorporated as well. Part of: cockroachdb#105820 Release note: None
AlexTalks
force-pushed
the
log_trace_at_rpc
branch
from
ee6e8c1 to
1f76649
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #106363, the receiver side of snapshots was modified to log the trace of the current context when context errors (such as timeouts or client-side context cancellation) occur. This refactors that change to log these traces whenever there is any context-based errors that occur during receiver-side handling of the
MultiRaft/RaftSnapshotstreaming RPC. This includes errors while receiving requests or sending responses from the server side of a snapshot - i.e. any time that the traces cannot be collected and returned to the client.Additionally, testing for these scenarios has been incorporated as well.
Part of: #105820
Release note: None