release-23.1: sql: fix pausable portal execution of apply joins with subqueries #106728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers-crl[bot]](https://avatars.githubusercontent.com/in/59700?s=60&v=4){kind=small}
Previously, when executing a query with an apply join with "inner" subqueries via pausable portals model we would crash because we'd incorrectly apply the "pausable portal" execution model to those "inner" subqueries (even though they need to be executed completely). We already disabled this execution model for the main "inner" query, but it should be disabled for the whole apply join iteration. I decided to not include a release note given that pausable portals are disabled by default and apply joins with inner subqueries seem like an edge case. Release note: None
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.1-106659
branch
from
34e1bd5 to
33d9ef8
Compare
blathers-crl
bot
added
blathers-backport
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.1-106659
branch
from
1e8670e to
52aa57f
Compare
|
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
|
This change is |
rharding6373
approved these changes
Jul 12, 2023
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #106659 on behalf of @yuzefovich.
/cc @cockroachdb/release
Previously, when executing a query with an apply join with "inner" subqueries via pausable portals model we would crash because we'd incorrectly apply the "pausable portal" execution model to those "inner" subqueries (even though they need to be executed completely). We already disabled this execution model for the main "inner" query, but it should be disabled for the whole apply join iteration.
I decided to not include a release note given that pausable portals are disabled by default and apply joins with inner subqueries seem like an edge case.
Epic: None
Release note: None
Release justification: bug fix.