roachtest: backport improvements to mixedversion framework (secure clusters, fixtures opt-out)
#106545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a number of small bugs related to using secure clusters in roachtests, which probably stayed dormant up to this point because we don't use secure clusters enough, especially in tests where nodes are restarted. In this commit, we avoid refetching certs when restarting, fix the checks for certificate existence on nodes, and fix the command to wipe a cluster when certs are to be preserved. Epic: none Release note: None
This parameter already existed in the underlying `cluster_synced` implemenation, but the `cluster` interface exposed to roachtsts forced that argument to `false`. This commit changes the interface to expose the parameter, allowing tests to wipe clusters while keeping the certs intact. Epic: none Release note: None
Secure clusters are closer to production deployments and also allow us to tests features that we couldn't before, like creating new users with passwords during a test, and then performing SQL operations with those users. Epic: CRDB-19321 Release note: None
The `loadTPCHDataset` function was unconditionally removing certs when the cluster was wiped. In this commit, we add a parameter to that function to indicate if the cluster being used is `secure`; if so, we preserve the certs when wiping. Fixes: cockroachdb#105880 Release note: None
This commit updates the `mixedversion` API with two main changes: * cluster validation: previously, mixed-version tests would always start from checked-in fixtures. Those fixtures have an implied cluster topology and require the cluster to have 4 cockroach nodes -- if that's not the case, the cluster fails to start up with non-obvious error messages. To make this situation clearer, we now validate that the test is being run with the correct number of nodes. * to allow for larger-scale mixed-version tests (more than 4 nodes), we now expose a `DisableFixtures` option that can be passed to `NewTest`. With this option, nodes start with an empty store directory, eliminating any restrictions on cluster size. Epic: CRDB-19321 Release note: None
renatolabs
requested review from
herkolategan and
smg260
and removed request for
a team
|
This change is |
|
Currently running:
|
srosenberg
approved these changes
Jul 11, 2023
It needed changes to work with secure clusters, including authenticating with the server before performing the `curl` call for the endpoint being tested. Epic: none Release note: None
|
Test is running here, if everything goes well I'll proceed with the merge: https://teamcity.cockroachdb.com/viewQueued.html?itemId=10867137&tab=queuedBuildOverviewTab. FYI @THardy98. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports:
mixedversionto always use secure clusters" (roachtest: updatemixedversionto always use secure clusters #105454)Please see individual PRs for details.
/cc @cockroachdb/release
Epic: none
Release note: None
Release justification: test-only changes.