Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: don't use goimports for goyacc #106544

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

rickystewart
Copy link
Collaborator

We use goimports to clean up (add/remove imports) code. This is unnecessary as we know what code we need.

Part of #106541.
Epic: CRDB-8308
Release note: None

@rickystewart rickystewart requested a review from rail July 10, 2023 19:43
@rickystewart rickystewart requested a review from a team as a code owner July 10, 2023 19:43
@blathers-crl
Copy link

blathers-crl bot commented Jul 10, 2023

It looks like your PR touches SQL parser code but doesn't add or edit parser tests. Please make sure you add or edit parser tests if you edit the parser.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

We use `goimports` to clean up (add/remove imports) code. This is
unnecessary as we know what code we need.

Part of cockroachdb#106541.
Epic: CRDB-8308
Release note: None
@rickystewart
Copy link
Collaborator Author

TFTRs!

bors r=knz,rail

@rickystewart rickystewart added the backport-23.1.x Flags PRs that need to be backported to 23.1 label Jul 11, 2023
@craig
Copy link
Contributor

craig bot commented Jul 11, 2023

Build succeeded:

@craig craig bot merged commit 7d6600e into cockroachdb:master Jul 11, 2023
@blathers-crl
Copy link

blathers-crl bot commented Jul 11, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from d2be37f to blathers/backport-release-23.1-106544: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants