-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: deps: update golang.org/x/tools #106533
release-23.1: deps: update golang.org/x/tools #106533
Conversation
The patch updates golang.org/x/term from v0.6.0 to v0.7.0. The update is in part motivated by spurious nogo compilation errors tracked in cockroachdb#99988. Informs cockroachdb#99988 Release note: None
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
qq: is it necessary to re- |
Unfortunately this was not really a clean backport (as there was a conflict) but it was quite close. To answer the question, generally no. For example in this case only the backport (once the conflicts were resolved) was actually necessary. Out of an abundance of caution I re-ran Note that failing to For (clean) backports, the extra |
good to know! |
TFTRs! |
Backport 1/1 commits from #106256.
/cc @cockroachdb/release
The patch updates golang.org/x/term from v0.6.0 to v0.7.0. The update is in part motivated by spurious nogo compilation errors tracked in #99988.
Informs: #99988
Release note: None
Epic: none
Release justification: fix spurious
nogo
errors in build