Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: server: fix crdb_internal.cluster_inflight_traces in shared process mode #106457

Merged

Conversation

yuzefovich
Copy link
Member

@yuzefovich yuzefovich commented Jul 7, 2023

Backport 1/1 commits from #106238.

/cc @cockroachdb/release


This commit fixes a panic that would previously occur when querying crdb_internal.cluster_inflight_traces virtual table when running in shared-process multi-tenant mode. In particular, the problem was that we tried to access node liveness which isn't available, and now we will fall back to the multi-tenant way of doing things (using the instances reader). Additionally, this commit extends the existing test to also run in shared-process multi-tenant config which serves as a regression test for this bug. There is no release note since it's not a user-visible bug.

Fixes: #106182.
Epic: CRDB-26691

Release note: None

Release justification: bug fix.

This commit fixes a panic that would previously occur when querying
`crdb_internal.cluster_inflight_traces` virtual table when running in
shared-process multi-tenant mode. In particular, the problem was that we
tried to access node liveness which isn't available, and now we will
fall back to the multi-tenant way of doing things (using the instances
reader). Additionally, this commit extends the existing test to also run
in shared-process multi-tenant config which serves as a regression test
for this bug. There is no release note since it's not a user-visible
bug.

Release note: None
@yuzefovich yuzefovich requested review from knz and a team July 7, 2023 22:12
@yuzefovich yuzefovich requested a review from a team as a code owner July 7, 2023 22:12
@blathers-crl
Copy link

blathers-crl bot commented Jul 7, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@yuzefovich yuzefovich merged commit d1016b7 into cockroachdb:release-23.1 Jul 8, 2023
@yuzefovich yuzefovich deleted the backport23.1-106238 branch July 8, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants