c2c: refactor eventStream to track batch in seperate streamEventBatcher #106444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
msbutler
force-pushed
the
butler-producer-batch-refactor
branch
5 times, most recently
from
a20f3bb to
4b2e2f0
Compare
|
unrelated flake |
msbutler
requested review from
dt and
stevendanna
and removed request for
a team and
dt
lidorcarmel
reviewed
Jul 14, 2023
msbutler
force-pushed
the
butler-producer-batch-refactor
branch
3 times, most recently
from
d006d86 to
baf383c
Compare
stevendanna
approved these changes
Jul 14, 2023
| "github.com/cockroachdb/cockroach/pkg/roachpb" | ||
| ) | ||
|
|
||
| type batchManager struct { |
There was a problem hiding this comment.
When I see manager I typically think of something that oversees a collection of a thing. But, let's not bikeshed the name.
There was a problem hiding this comment.
refactored to streamEventBatcher. we can further bikeshed after this pr merges :)
| @@ -39,6 +39,7 @@ import ( | |||
| func ScanSST( | |||
| sst *kvpb.RangeFeedSSTable, | |||
| scanWithin roachpb.Span, | |||
| // TODO (msbutler): I think we can use a roachpb.kv instead, avoiding EncodeDecode roundtrip. | |||
msbutler
force-pushed
the
butler-producer-batch-refactor
branch
3 times, most recently
from
988f91e to
3bdbc20
Compare
This is a small refactor cleans up the streamLoop() in the eventStream and makes it easier to emit spanConfig protos for zone config replication. Epic: none Release note: None
msbutler
force-pushed
the
butler-producer-batch-refactor
branch
from
3bdbc20 to
8a2b868
Compare
msbutler
changed the title
|
bors r=stevendanna |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small refactor cleans up the streamLoop() in the eventStream and makes it easier to emit spanConfig protos for zone config replication.
Epic: none
Release note: None