-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: fix nil pointer dereference in crdb_internal.transaction_contention_events #106185
sql: fix nil pointer dereference in crdb_internal.transaction_contention_events #106185
Conversation
…ion_events schemaDesc was not checked for a nil pointer before dereferencing it. schemaDesc can be nil under the following conditions: 1. A schema descriptor can be deleted, in which case all of its tables would be deleted too. 2. The transaction used to retrieve the descriptor fails. Given the structure of `getContentionEventInfo`, this nil pointer dereference is only possible under scenario 2. If a schema and its tables are deleted, a nil table descriptor would force an early return, and this code path would not execute. Fixes: cockroachdb#104406 Epic: none Release note: None
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! 2 of 0 LGTMs obtained (waiting on @zachlite)
bors r+ |
TFTRs! |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error setting reviewers, but backport branch blathers/backport-release-23.1-106185 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/106210/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. [] Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
schemaDesc
was not checked for a nil pointer before dereferencing it.schemaDesc
can be nil under the following conditions:A schema descriptor can be deleted, in which case all of its tables would be deleted too.
The transaction used to retrieve the descriptor fails.
Given the structure of
getContentionEventInfo
, this nil pointer dereference is only possible under scenario 2: If a schema and its tables are deleted, a nil table descriptor would force an early return, and this code path would not execute.Fixes: #104406
Epic: none
Release note: None