Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/ui: emphasize "cluster virtualization" in human-visible surfaces #106118

Merged

Conversation

knz
Copy link
Contributor

@knz knz commented Jul 4, 2023

Informs #106068.
Epic: CRDB-29380

At this stage, we are focusing on strings and comments that are read by humans. A separate pass will take care of the method and variable names later.

Release note: None

@knz knz added A-multitenancy Related to multi-tenancy backport-23.1.x Flags PRs that need to be backported to 23.1 labels Jul 4, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz force-pushed the 20230704-ui-visible-elements-virtual-cluster branch from 7d1e4ab to b4731bc Compare July 4, 2023 16:22
@knz knz requested review from stevendanna and yuzefovich July 4, 2023 16:24
@knz knz marked this pull request as ready for review July 4, 2023 17:46
@knz knz requested a review from a team July 4, 2023 17:46
Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @stevendanna)

At this stage, we are focusing on strings and comments that are read
by humans. A separate pass will take care of the method and variable
names later.

Release note: None
@knz knz force-pushed the 20230704-ui-visible-elements-virtual-cluster branch from b4731bc to 69b9cac Compare October 2, 2023 16:00
@knz
Copy link
Contributor Author

knz commented Oct 2, 2023

TFYR!

bors r=yuzefovich

@craig
Copy link
Contributor

craig bot commented Oct 2, 2023

Build succeeded:

@craig craig bot merged commit 0be8311 into cockroachdb:master Oct 2, 2023
@knz knz deleted the 20230704-ui-visible-elements-virtual-cluster branch October 3, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-multitenancy Related to multi-tenancy backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants