roachtest: restart-one-node to use explicit addrs #106098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test is restarting one node with modified start params. It was not passing advertise-addr option which lead to hostname picked being unaccessible from other cluster nodes. This commit changes test to provide explicit address upon restart. Fixes cockroachdb#105972 Release note: None
aliher1911
requested review from
srosenberg and
smg260
and removed request for
a team
|
This change is |
erikgrinaker
approved these changes
Jul 4, 2023
|
TFTR |
|
Build succeeded: |
This was referenced Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test is restarting one node with modified start params. It was not passing advertise-addr option which lead to hostname picked being unaccessible from other cluster nodes. This commit changes test to provide explicit address upon restart.
Fixes #105972
Release note: None