opt/exec: add passthrough cols to DELETE USING result cols in explain #105932
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball and @michae2)
-- commits line 9 at r1:
nit: s/sql change/bug fix/. Also perhaps mention that the bug was introduced in 23.1.0.
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:
Now that we support `DELETE USING`, delete nodes can have passthrough columns. Add these to the result columns used by `EXPLAIN (TYPES)`. Fixes: cockroachdb#105803 Release note (bug fix): Fix an internal error when using `EXPLAIN (TYPES)` on a `DELETE FROM ... USING ... RETURNING` statement which was introduced in v23.1.0.
michae2
force-pushed
the
deleteUsingExplain
branch
from
df83ab2 to
5960881
Compare
There was a problem hiding this comment.
TFTRs!
bors r=yuzefovich,DrewKimball
Reviewable status:
Previously, yuzefovich (Yahor Yuzefovich) wrote…
nit:
s/sql change/bug fix/. Also perhaps mention that the bug was introduced in 23.1.0.
Good point! Done.
|
Build succeeded: |
Now that we support
DELETE USING, delete nodes can have passthrough columns. Add these to the result columns used byEXPLAIN (TYPES).Fixes: #105803
Release note (sql change): Fix an internal error when using
EXPLAIN (TYPES)on aDELETE FROM ... USING ... RETURNINGstatement.