persistedsqlstats: de-flake TestSQLStatsPersistedLimitReached #105917
Conversation
|
This change is |
zachlite
force-pushed
the
230628.flush_test_flake
branch
from
9ba1daa to
dc4da0a
Compare
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @zachlite)
pkg/sql/sqlstats/persistedsqlstats/flush_test.go line 495 at r1 (raw file):
sqlConn.Exec(t, "SELECT 1, 2, 3") s.SQLServer().(*sql.Server).
nit: create func or a variable to point to persisted stats to avoid the long line everywhere it is called
zachlite
force-pushed
the
230628.flush_test_flake
branch
from
dc4da0a to
f93c423
Compare
There was a problem hiding this comment.
TFTR!
Reviewable status:
pkg/sql/sqlstats/persistedsqlstats/flush_test.go line 495 at r1 (raw file):
Previously, j82w (Jake) wrote…
nit: create func or a variable to point to persisted stats to avoid the long line everywhere it is called
Done.
TestSQLStatsPersistedLimitReached would previously flake because it did not consider background SQL activity happening in the cluster. This commit re-writes the test to only make assertions that are not dependent on background cluster activity. Resolves cockroachdb#105846, cockroachdb#97488 Epic: none Release note: None
zachlite
force-pushed
the
230628.flush_test_flake
branch
from
f93c423 to
a9a8a57
Compare
|
bors r+ |
|
Build succeeded: |
|
NB: the following line will only auto-close #105846. for it to work properly, each issue needs to be listed separately, like: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue |
Thanks Rafi! |
TestSQLStatsPersistedLimitReached would previously flake because it did not consider background SQL activity happening in the cluster.
This commit re-writes the test to only make assertions that are not dependent on background cluster activity.
Resolves #105846, #97488
Epic: none
Release note: None