release-23.1: kvserver: deflake TestPromoteNonVoterInAddVoter #105889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/2 commits from #103083.
/cc @cockroachdb/release
It is possible for span config updates to arrive at different times
between stores.
TestPromoteNonVoterInAddVoter
was flaking when theincoming leaseholder would act upon a stale span config, before
receiving the updated one which the outgoing leaseholder used.
This resulted in the test failing as more than just the two expected
promotion events appeared in the range log, as the incoming leaseholder
removed voters, then subsequently added them back upon receiving the
up to date span configuration.
#103086 tracks this issue.
This PR checks on the prefix of the range log add voter events, to
avoid failing the test when this untimely behavior occurs.
Stressed overnight, removing the skip under stress flag:
This PR also adds additional (v=6) logging of the range descriptor and span config,
as these come in handy when debugging failures such as this.
Fixes: #101519
Release note: None
Informs: #105883
Release justification: Test only change.