-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sqlstats, builtins: add builtin to reset activity tables #105841
sqlstats, builtins: add builtin to reset activity tables #105841
Conversation
f2c9574
to
1e501fa
Compare
This change introduces `crdb_internal.reset_activity_tables` to reset the statistics in the `system.{statement|transaction}_activity` tables. This is useful as an escape hatch for cases when we have stale/inaccurate statistics in the tables (i.e. if the activity job was cancelled). Users need `admin` to use this builtin. Release note (sql change): Add `crdb_internal.reset_activity_tables` builtin to allow users to reset the statistics in the `system.{statement|transaction}_activity` tables. Users require `admin` to use this builtin.
1e501fa
to
d3d2499
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 6 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained
bors r+ |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error setting reviewers, but backport branch blathers/backport-release-23.1-105841 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/106129/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. [] Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Resolves: #105843
This change introduces
crdb_internal.reset_activity_tables
to reset the statistics in thesystem.{statement|transaction}_activity
tables. This is useful as an escape hatch for cases when we have stale/inaccurate statistics in the tables (i.e. if the activity job was cancelled). Users needadmin
to use this builtin.Release note (sql change): Add
crdb_internal.reset_activity_tables
builtin to allow users to reset the statistics in thesystem.{statement|transaction}_activity
tables. Users requireadmin
to use this builtin.