Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlstats, builtins: add builtin to reset activity tables #105841

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

THardy98
Copy link

@THardy98 THardy98 commented Jun 29, 2023

Resolves: #105843

This change introduces crdb_internal.reset_activity_tables to reset the statistics in the system.{statement|transaction}_activity tables. This is useful as an escape hatch for cases when we have stale/inaccurate statistics in the tables (i.e. if the activity job was cancelled). Users need admin to use this builtin.

Release note (sql change): Add crdb_internal.reset_activity_tables builtin to allow users to reset the statistics in the system.{statement|transaction}_activity tables. Users require admin to use this builtin.

@THardy98 THardy98 requested a review from a team as a code owner June 29, 2023 18:54
@THardy98 THardy98 requested a review from a team June 29, 2023 18:54
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@THardy98 THardy98 added the backport-23.1.x Flags PRs that need to be backported to 23.1 label Jun 29, 2023
@THardy98 THardy98 force-pushed the reset_activity_tables_builtin branch from f2c9574 to 1e501fa Compare June 29, 2023 19:45
This change introduces `crdb_internal.reset_activity_tables` to reset
the statistics in the `system.{statement|transaction}_activity` tables.
This is useful as an escape hatch for cases when we have
stale/inaccurate statistics in the tables (i.e. if the activity job was
cancelled). Users need `admin` to use this builtin.

Release note (sql change): Add `crdb_internal.reset_activity_tables`
builtin to allow users to reset the statistics in the
`system.{statement|transaction}_activity` tables. Users require `admin`
to use this builtin.
@THardy98 THardy98 force-pushed the reset_activity_tables_builtin branch from 1e501fa to d3d2499 Compare June 29, 2023 20:21
Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@THardy98
Copy link
Author

THardy98 commented Jul 4, 2023

bors r+

@craig
Copy link
Contributor

craig bot commented Jul 4, 2023

Build succeeded:

@blathers-crl
Copy link

blathers-crl bot commented Jul 4, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error setting reviewers, but backport branch blathers/backport-release-23.1-105841 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/106129/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 23.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sqlstats: add ability to reset the statement_activity and transaction_activity system tables
3 participants