release-22.2: geo: fix nan handling in bounding box comparison #105829
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #105789 on behalf of @rharding6373.
/cc @cockroachdb/release
Go always returns false when comparing float NaNs, but SQL expects NaNs to be less than any other float value. Before this change, the geo package's
CartesianBoundingBox
did not have special handling for NaNs, so it implemented the go behavior, which is incorrect for our use case.This change adds correct NaN comparison behavior to bounding boxes.
Epic: None
Fixes: #93541
Fixes: #102661
Release note (bug fix): Fixes a bug in the geospatial cartesian bounding box type that had incorrect behavior when comparing boxes with NaN values.
Release justification: Fixes incorrect edge case behavior in geospatial.