Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: geo: fix nan handling in bounding box comparison #105829

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jun 29, 2023

Backport 1/1 commits from #105789 on behalf of @rharding6373.

/cc @cockroachdb/release


Go always returns false when comparing float NaNs, but SQL expects NaNs to be less than any other float value. Before this change, the geo package's CartesianBoundingBox did not have special handling for NaNs, so it implemented the go behavior, which is incorrect for our use case.

This change adds correct NaN comparison behavior to bounding boxes.

Epic: None
Fixes: #93541
Fixes: #102661

Release note (bug fix): Fixes a bug in the geospatial cartesian bounding box type that had incorrect behavior when comparing boxes with NaN values.


Release justification: Fixes incorrect edge case behavior in geospatial.

Go always returns false when comparing float NaNs, but SQL expects NaNs
to be less than any other float value. Before this change, the geo
package's `CartesianBoundingBox` did not have special handling for NaNs,
so it implemented the go behavior, which is incorrect for our use case.

This change adds correct NaN comparison behavior to bounding boxes.

Epic: None
Fixes: #93541
Fixes: #102661

Release note (bug fix): Fixes a bug in the geospatial cartesian bounding
box type that had incorrect behavior when comparing boxes with NaN
values.
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-105789 branch from 552ade7 to 4749719 Compare June 29, 2023 16:59
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jun 29, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Jun 29, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-105789 branch from 64f287f to 2e4bd1d Compare June 29, 2023 16:59
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rharding6373 rharding6373 requested a review from otan June 29, 2023 17:08
@rharding6373 rharding6373 merged commit 2decc53 into release-22.2 Jun 29, 2023
@rharding6373 rharding6373 deleted the blathers/backport-release-22.2-105789 branch June 29, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants