sql: return unimplemented error for plpgsql udfs with record input #105738
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @DrewKimball)
pkg/sql/opt/optbuilder/create_function.go line 153 at r1 (raw file):
"SQL functions cannot have arguments of type record")) } else if language == tree.FunctionLangPLpgSQL { panic(unimplemented.NewWithIssueDetail(105713,
Sorry, I meant to include this in a previous PR but forgot to amend to the commit.
PLpgSQL UDFs should support `RECORD` argument types as input, but there are currently issues with assignment of underlying tuple types in `RECORD`s that prevent CRDB from supporting them. We explicitly note this feature as unsupported until the issues are resolved. Epic: None Informs: cockroachdb#105713 Release note: None
rharding6373
force-pushed
the
20230626_udf_values_type_res_105120
branch
from
d596886 to
6ba83d8
Compare
There was a problem hiding this comment.
Sorry, I meant to include this in a previous PR but forgot to amend to the commit.
No worries, thanks for the fix!
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:
|
TFTR! bors r+ |
|
Build succeeded: |
PLpgSQL UDFs should support
RECORDargument types as input, but there are currently issues with assignment of underlying tuple types inRECORDs that prevent CRDB from supporting them. We explicitly note this feature as unsupported until the issues are resolved.Epic: None
Informs: #105713
Release note: None