Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "storage: use size-carrying point tombstones" #105718

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Revert "storage: use size-carrying point tombstones" #105718

merged 1 commit into from
Jun 28, 2023

Conversation

jbowens
Copy link
Collaborator

@jbowens jbowens commented Jun 28, 2023

This reverts commit 8edbf0f.

Epic: none
Release note: none
Informs #105700.
Informs #105697.

@jbowens
Revert "storage: use size-carrying point tombstones"
90c1ee6 
This reverts commit 8edbf0f.

Epic: none
Release note: none
@jbowens jbowens requested review from erikgrinaker and tbg June 28, 2023 14:21
@jbowens jbowens requested review from a team as code owners June 28, 2023 14:21
@jbowens jbowens requested review from a team, smg260, renatolabs and sumeerbhola and removed request for a team June 28, 2023 14:21
@cockroach-teamcity
Copy link
Member

This change is Reviewable

tbg
tbg approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@tbg tbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't reviewed the diff line by line, so assuming this is a clean revert.

@jbowens
Copy link
Collaborator Author

jbowens commented Jun 28, 2023

Yeah, it was a clean revert.

TFTRs!

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 28, 2023

Build succeeded:

@craig craig bot merged commit 3c54e12 into cockroachdb:master Jun 28, 2023
@jbowens jbowens deleted the revert-delsized branch June 28, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbg tbg tbg approved these changes

@erikgrinaker erikgrinaker erikgrinaker approved these changes

@smg260 smg260 Awaiting requested review from smg260 smg260 was automatically assigned from cockroachdb/test-eng

@renatolabs renatolabs Awaiting requested review from renatolabs renatolabs was automatically assigned from cockroachdb/test-eng

@sumeerbhola sumeerbhola Awaiting requested review from sumeerbhola sumeerbhola is a code owner automatically assigned from cockroachdb/storage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbowens @cockroach-teamcity @erikgrinaker @tbg