Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: unskip TestStatusEngineStatsJson #105629

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Conversation

knz
Copy link
Contributor

@knz knz commented Jun 27, 2023

Fixes #99261.

We have fixed the issue that caused the skip in #103764.

Release note: None

We have fixed the issue that caused the skip in cockroachdb#103764.

Release note: None
@knz knz requested review from rafiss, ericharmeling and a team June 27, 2023 15:51
@knz knz requested a review from a team as a code owner June 27, 2023 15:51
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss added the backport-23.1.x Flags PRs that need to be backported to 23.1 label Jun 27, 2023
@knz
Copy link
Contributor Author

knz commented Jun 27, 2023

TFYR!

bors r=rafiss

@craig
Copy link
Contributor

craig bot commented Jun 27, 2023

Build succeeded:

@craig craig bot merged commit 08343f5 into cockroachdb:master Jun 27, 2023
@blathers-crl
Copy link

blathers-crl bot commented Jun 27, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error setting reviewers, but backport branch blathers/backport-release-23.1-105629 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/105637/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 23.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

server: TestStatusEngineStatsJson failed
3 participants