Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: tree,optbuilder: store annotations for each UDF body statement #105617

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Jun 27, 2023

This also fixes a related issue where user-defined types that was
references in UDF bodies would not be shown in the CREATE FUNCTION
statement. This problem was being masked by the main issue that is
getting fixed.

Release note (bug fix): Previously, referencing a user-defined type in
the body of a user-defined function would result in an error at the time
of creating the function. This is now fixed.

Backport:

Please see individual PRs for details.

/cc @cockroachdb/release

Release justification: bug fix
fixes #104242

@rafiss rafiss requested review from Xiang-Gu and DrewKimball June 27, 2023 14:43
@rafiss rafiss requested review from a team as code owners June 27, 2023 14:43
@blathers-crl
Copy link

blathers-crl bot commented Jun 27, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

rafiss added 2 commits June 28, 2023 00:14
This also fixes a related issue where user-defined types that was
references in UDF bodies would not be shown in the CREATE FUNCTION
statement. This problem was being masked by the main issue that is
getting fixed.

Release note (bug fix): Previously, referencing a user-defined type in
the body of a user-defined function would result in an error at the time
of creating the function. This is now fixed.
In 22dabb0 we started overriding the annotations for each statement
in the UDF body. We should reset them to the original values, so we
don't accidentally leave the old reference.

Release note: None
@rafiss rafiss force-pushed the backport23.1-105465-105581 branch from 2aa9dfe to 7e6f336 Compare June 28, 2023 04:14
Copy link
Collaborator

@DrewKimball DrewKimball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @Xiang-Gu)

@rafiss rafiss merged commit 2b420ba into cockroachdb:release-23.1 Jun 29, 2023
@rafiss rafiss deleted the backport23.1-105465-105581 branch June 29, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants