Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: convenience syntax ALTER TENANT GRANT/REVOKE ALL CAPABILITIES #105609

Merged
merged 1 commit into from
Jun 28, 2023
Merged

sql: convenience syntax ALTER TENANT GRANT/REVOKE ALL CAPABILITIES #105609

merged 1 commit into from
Jun 28, 2023

Conversation

knz
Copy link
Contributor

@knz knz commented Jun 27, 2023

Fixes #105607.
Epic: CRDB-26691

This change makes it possible to grant/revoke all capabilities simultaneously with the syntax ALL CAPABILITIES.

Release note: None

@knz
sql: convenience syntax ALTER TENANT GRANT/REVOKE ALL CAPABILITIES
4fafef0 
This change makes it possible to grant/revoke all capabilities
simultaneously with the syntax `ALL CAPABILITIES`.

Release note: None
@knz knz requested a review from yuzefovich June 27, 2023 12:02
@knz knz requested review from a team as code owners June 27, 2023 12:02
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz mentioned this pull request Jun 27, 2023
Merged
@knz knz added the A-multitenancy Related to multi-tenancy label Jun 27, 2023
yuzefovich
yuzefovich approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @knz)

@knz
Copy link
Contributor Author

knz commented Jun 27, 2023

bors r=yuzefovich

@knz knz added the backport-23.1.x Flags PRs that need to be backported to 23.1 label Jun 27, 2023
@craig
Copy link
Contributor

craig bot commented Jun 27, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Jun 28, 2023

Build succeeded:

@craig craig bot merged commit 13e94b6 into cockroachdb:master Jun 28, 2023
@blathers-crl blathers-crl bot mentioned this pull request Jun 28, 2023
Merged
@blathers-crl
Copy link

blathers-crl bot commented Jun 28, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

error setting reviewers, but backport branch blathers/backport-release-23.1-105609 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/105675/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 23.1.x failed. See errors above.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuzefovich yuzefovich yuzefovich approved these changes

Assignees
No one assigned
Labels
A-multitenancy Related to multi-tenancy backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sql: make it easy(ier) to grant all capabilities to a secondary tenant
3 participants
@knz @cockroach-teamcity @yuzefovich