kv: unskip TestSystemZoneConfigs #105594
Closed
kv: unskip TestSystemZoneConfigs #105594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestSystemZoneConfigs was part of a batch of skipped tests [1]. It appears several tests in that batch flaked due to a "slow quiesce" issue. The root cause for TestSystemZoneConfigs flaking during that time remains unknown, yet the other tests in the same batch have since been unskipped. After stress-testing via, ``` ./dev test pkg/kv/kvserver -f=TestSystemZoneConfigs --stress --stress-args '-maxruns 10000 -p 23' --timeout=10m ``` we surmise this test might have been indirectly deflaked. Thus, we unskip it. [1] cockroachdb#99121 Epic: none Fixes: cockroachdb#98905 Release note: None
|
This change is |
srosenberg
added
backport-23.1.x
knz
approved these changes
Jun 27, 2023
|
We can't unskip a killed test [1], so closing on those grounds. [1] #104198 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestSystemZoneConfigs was part of a batch of skipped tests [1]. It appears several tests in that batch flaked due to a "slow quiesce" issue. The root cause for TestSystemZoneConfigs flaking during that time remains unknown, yet the other tests in the same batch have since been unskipped.
After stress-testing via,
we surmise this test might have been indirectly deflaked. Thus, we unskip it.
[1] #99121
Epic: none
Fixes: #98905
Release note: None