Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: re-add encoding test for pg_lsn #105554

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

otan
Copy link
Contributor

@otan otan commented Jun 26, 2023

I committed the json but not the binary test. Woops!

Informs: #105130

Release note: None

I committed the json but not the binary test. Woops!

Release note: None
@otan otan requested a review from rafiss June 26, 2023 16:00
@otan otan requested a review from a team as a code owner June 26, 2023 16:00
@blathers-crl
Copy link

blathers-crl bot commented Jun 26, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@otan
Copy link
Contributor Author

otan commented Jun 26, 2023

bors r=rafiss

@craig
Copy link
Contributor

craig bot commented Jun 26, 2023

Build succeeded:

@craig craig bot merged commit 7c9e0d1 into cockroachdb:master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants