-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kvserver: Fix WAL Bytes Written Metrics #105536
Conversation
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @RahulAggarwal1016)
pkg/kv/kvserver/metrics.go
line 2037 at r1 (raw file):
} metaWALBytesWritten = metric.Metadata{ Name: "storage.wal.bytes_written",
Let's update the graph to use this metric name, not the other way around. We no longer use RocksDB, so we don't want to introduce new metrics that use the rocksdb name.
3e3ef98
to
b166595
Compare
bdff693
to
37284f0
Compare
37284f0
to
633ac32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @RahulAggarwal1016)
Currently the number of WAL bytes written does not show up. This pr fixes that by using a consistent metric name. Informs: cockroachdb#104531 Release note: None
633ac32
to
3eb6d6a
Compare
bors r+ |
Build succeeded: |
Currently the number of WAL bytes written does not show up. This pr fixes that by using a consistent metric name.
Informs: #104531
Release note: None