Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: Fix WAL Bytes Written Metrics #105536

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

raggar
Copy link
Contributor

@raggar raggar commented Jun 26, 2023

Currently the number of WAL bytes written does not show up. This pr fixes that by using a consistent metric name.

Informs: #104531
Release note: None

@raggar raggar requested a review from a team as a code owner June 26, 2023 14:05
@blathers-crl
Copy link

blathers-crl bot commented Jun 26, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @RahulAggarwal1016)


pkg/kv/kvserver/metrics.go line 2037 at r1 (raw file):

	}
	metaWALBytesWritten = metric.Metadata{
		Name:        "storage.wal.bytes_written",

Let's update the graph to use this metric name, not the other way around. We no longer use RocksDB, so we don't want to introduce new metrics that use the rocksdb name.

@raggar raggar force-pushed the rahul_fix_wal_metrics branch from 3e3ef98 to b166595 Compare June 26, 2023 14:11
@raggar raggar requested a review from a team June 26, 2023 14:11
@raggar raggar force-pushed the rahul_fix_wal_metrics branch 3 times, most recently from bdff693 to 37284f0 Compare June 26, 2023 14:14
@raggar raggar requested a review from jbowens June 26, 2023 14:14
@raggar raggar force-pushed the rahul_fix_wal_metrics branch from 37284f0 to 633ac32 Compare June 26, 2023 14:25
Copy link
Collaborator

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @RahulAggarwal1016)

Currently the number of WAL bytes written does not show up. This pr
fixes that by using a consistent metric name.

Informs: cockroachdb#104531
Release note: None
@raggar raggar force-pushed the rahul_fix_wal_metrics branch from 633ac32 to 3eb6d6a Compare June 26, 2023 18:22
@raggar
Copy link
Contributor Author

raggar commented Jun 27, 2023

bors r+

@craig
Copy link
Contributor

craig bot commented Jun 27, 2023

Build succeeded:

@craig craig bot merged commit c7965ed into cockroachdb:master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants