Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: sql: add default_value and origin to show cluster settings #105452

Merged
merged 2 commits into from
Jun 23, 2023
Merged

release-23.1: sql: add default_value and origin to show cluster settings #105452

merged 2 commits into from
Jun 23, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Jun 23, 2023 •
edited by maryliag
Loading

Backport 2/2 commits from #104449 on behalf of @maryliag.

/cc @cockroachdb/release

Fixes https://cockroachlabs.atlassian.net/browse/CRDB-28519

Commit 1
This adds an API to the settings package to track the origin of the current value of each setting, such as whether it is set by the the default value, an explicit override or an external override.

Commit 2
Previously, there was no easy way to see default values for
cluster settings. This commit add the column for default_value
and origin to crdb_internal.cluster_settings and
the show cluster settings command.

Release note (sql change): Add columns default_value and
origin (default, override, external-override) to the
show cluster settings command.

Release justification: feature improvement

dt and others added 2 commits June 6, 2023 22:25
@dt
settings: track the origin of the current values
524615f 
This adds an API to the settings package to track the origin of the
current value of each setting, such as whether it is set by the the
default value, an explicit override or an external override.

Release note: none.
Epic: none.
@maryliag
sql: add default_value and is_overridden to cluster settings
866a971 
Fixes https://cockroachlabs.atlassian.net/browse/CRDB-28519

Previously, there was no easy way to see default values for
cluster settings. This commit add the column for `default_value`
and `origin` to `crdb_internal.cluster_settings` and
the `show cluster settings` command.

Release note (sql change): Add columns `default_value` and
`origin` (default, override, external-override) to the
`show cluster settings` command.
@blathers-crl blathers-crl bot requested review from a team as code owners June 23, 2023 18:28
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-104449 branch from 524615f to e984cee Compare June 23, 2023 18:28
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Jun 23, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-104449 branch from a15d808 to 866a971 Compare June 23, 2023 18:28
@blathers-crl
Copy link
Author

blathers-crl bot commented Jun 23, 2023 •
edited by maryliag
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@maryliag maryliag requested review from a team and removed request for a team June 23, 2023 18:29
@maryliag maryliag merged commit 708c123 into release-23.1 Jun 23, 2023
@maryliag maryliag deleted the blathers/backport-release-23.1-104449 branch June 23, 2023 19:52
@cockroach-teamcity cockroach-teamcity mentioned this pull request Jun 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xinhaoz xinhaoz xinhaoz approved these changes

Assignees

@maryliag maryliag

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cockroach-teamcity @xinhaoz @maryliag @dt