systemschema: stop running PostDeserializationChanges when building tables #105444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This table was missing from the list, and the expected count of tables was off since we weren't accounting for non-system tenant tables. The function is only used for testing, so there was no impact. Release note: None
…ables We would like to remove old PostDeserializationChanges that are no longer needed. In order to do so, we need to stop relying on them to build system tables. Instead, now we adjust the hard-coded system table descriptors and the related helpers so that they create valid descriptors. This needed two changes: - Update the ConstraintID for check constraints. - Update the primary index encoding so that it includes stored columns. Release note: None
rafiss
force-pushed
the
no-post-deserialization-system-schema
branch
from
0a740a2 to
d91fdc4
Compare
Xiang-Gu
approved these changes
Jun 26, 2023
@Xiang-Gu good question, yes we do. It is bors r=Xiang-Gu |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
systemschema: add JobInfo to MakeSystemTables helper
This table was missing from the list, and the expected count of tables
was off since we weren't accounting for non-system tenant tables.
The function is only used for testing, so there was no impact.
systemschema: stop running PostDeserializationChanges when building tables
We would like to remove old PostDeserializationChanges that are no
longer needed. In order to do so, we need to stop relying on them to
build system tables.
Instead, now we adjust the hard-coded system table descriptors and the
related helpers so that they create valid descriptors. This needed two
changes:
Epic: None
Release note: None